Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read ssh username from env variable #94049

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Read ssh username from env variable #94049

merged 1 commit into from
Aug 27, 2020

Conversation

harche
Copy link
Contributor

@harche harche commented Aug 17, 2020 •
edited

Signed-off-by: Harshal Patil harpatil@redhat.com

What type of PR is this?

/kind failing-test

What this PR does / why we need it:
Right now pull-kubernetes-node-crio1-18-e2e fails because it uses Fedora CoreOS image to run node tests. Fedora CoreOS only allows core user to ssh into the system.

Once this PR is merged, kubernetes/test-infra#18536 can be merged so that we can pass the user core to the node tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

No

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@harche
Read ssh username from env variable
9d5ca30 
Signed-off-by: Harshal Patil <harpatil@redhat.com>
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @harche. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 17, 2020
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 17, 2020
@harche harche mentioned this pull request Aug 17, 2020
Merged
@harche
Copy link
Contributor Author

harche commented Aug 17, 2020

/assign @tallclair

@dims
Copy link
Member

dims commented Aug 17, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2020
@dims
Copy link
Member

dims commented Aug 17, 2020

/assign @dashpole @sjenning
/unassign @tallclair

@k8s-ci-robot k8s-ci-robot assigned dashpole and sjenning and unassigned tallclair Aug 17, 2020
@harche
Copy link
Contributor Author

harche commented Aug 17, 2020

/test pull-kubernetes-integration

@sjenning
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2020
@SergeyKanzhelev
Copy link
Member

@sjenning you have approve rights here. Do you want to approve as well?

@harche
Copy link
Contributor Author

harche commented Aug 18, 2020

/milestone v1.19

@k8s-ci-robot
Copy link
Contributor

@harche: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member

dims commented Aug 23, 2020

/assign @oomichi

@oomichi
Copy link
Member

oomichi commented Aug 24, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2020
@harche
Copy link
Contributor Author

harche commented Aug 25, 2020

Thanks @dims and @oomichi. I was wondering who might have the authorization to assign the milestone tag.

@dims
Copy link
Member

dims commented Aug 25, 2020

@harche i do. waiting for the release to wrap up. will go ahead and apply 1.20

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Aug 25, 2020
@harche
Copy link
Contributor Author

harche commented Aug 25, 2020

@dims thanks!

@justaugustus
Copy link
Member

/test pull-kubernetes-conformance-kind-ga-only-parallel
ref: #94263

@dims
Copy link
Member

dims commented Aug 27, 2020

/test pull-kubernetes-conformance-kind-ga-only-parallel

@k8s-ci-robot k8s-ci-robot merged commit 3808650 into kubernetes:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@vishh vishh Awaiting requested review from vishh

Assignees

@sjenning sjenning

@oomichi oomichi

@dashpole dashpole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@harche @k8s-ci-robot @dims @sjenning @SergeyKanzhelev @oomichi @justaugustus @dashpole @tallclair